Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of atomic-polyfill. #1125

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Dec 23, 2022

Only use it when CAS is actually needed.

@Dirbaio Dirbaio force-pushed the remove-atomic-polyfill branch from 97d5486 to 03a6a54 Compare December 23, 2022 19:31
- Fixes race condition that could cause losing irqs (because `if flags != 0` was clearing all)
- Doesn't need CAS, which is nice for thumbv6.
Only use it when CAS is actually needed.
@Dirbaio Dirbaio force-pushed the remove-atomic-polyfill branch from 03a6a54 to 10c9cc3 Compare December 23, 2022 19:46
@Dirbaio
Copy link
Member Author

Dirbaio commented Dec 23, 2022

bors r+

bors bot added a commit that referenced this pull request Dec 23, 2022
1125: Remove unnecessary use of atomic-polyfill. r=Dirbaio a=Dirbaio

Only use it when CAS is actually needed.

Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
@bors
Copy link
Contributor

bors bot commented Dec 23, 2022

Build failed:

@Dirbaio Dirbaio merged commit 74fdd4c into master Dec 23, 2022
@bors bors bot deleted the remove-atomic-polyfill branch December 23, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant