You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The single header, although it looks "easier to use" at first, is really difficult to browse. Splitting the source file into multiple files is almost always the best idea.
style nit: I feel like you're overusing auto in the code. I mean, in this case, int is shorter ;) The general guideline I've heard is to use auto where it "increases readability", very subjective :)
There is some extra data copy that could be avoided. Consider going to C-arrays/memcpy for passing around some of the data?
Would be nice to have an asyncSend that accepts a lambda onComplete handler (something like std::function<void (Response)>)
The text was updated successfully, but these errors were encountered:
In this repo,It sounds like all the ideas you mentioned have already been implemented.
By the way, auto is quite beneficial for C++ development. Using auto extensively does not increase the cognitive load for developers; on the contrary, it can significantly reduce the burden on both developers and the compiler.
Your library seems very promising, but I thought I would let you know a few ideas I had while looking at it:
auto
in the code. I mean, in this case,int
is shorter ;) The general guideline I've heard is to useauto
where it "increases readability", very subjective :)memcpy
for passing around some of the data?asyncSend
that accepts a lambda onComplete handler (something likestd::function<void (Response)>
)The text was updated successfully, but these errors were encountered: