Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.0 breaks req and Finch #463

Closed
AntoineAugusti opened this issue Feb 5, 2025 · 5 comments
Closed

1.7.0 breaks req and Finch #463

AntoineAugusti opened this issue Feb 5, 2025 · 5 comments

Comments

@AntoineAugusti
Copy link

See wojtekmach/req#453 and sneako/finch#298
@AntoineAugusti AntoineAugusti changed the title 1.7 breaks req and Finch 1.7.0 breaks req and Finch Feb 5, 2025
@sevenseacat
Copy link
Contributor

#462

@sneako
Copy link
Contributor

sneako commented Feb 5, 2025

Here is the issue: https://github.com/elixir-mint/mint/pull/460/files#diff-a0327f35c336a333a3289bef3a12836dd8c8a503cfa0058e4c5a621606214bcdR533

We are missing a ? on :open

@sneako
Copy link
Contributor

sneako commented Feb 5, 2025

Ah, @sevenseacat already found it :) #462

@sevenseacat
Copy link
Contributor

This can be closed now :)

@AntoineAugusti
Copy link
Author

Thanks @sevenseacat and @whatyouhide. https://github.com/elixir-mint/mint/releases/tag/v1.7.1 works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AntoineAugusti @sevenseacat @sneako