Admonition block dark mode bug

[davydog187]

Adding this from my phone but looks like the highlight on text in the blocks needs adjustment

[josevalim]

@davydog187 it is the new spoiler tag! 😅

[josevalim]

I have pushed a fix but I have asked the designer to see if a dark mode variation of the blocks make sense. /cc @milmazz

[milmazz]

@josevalim Thanks for taking care of this. Once you have the feedback from the designer, please let me know. Then, I can apply the changes to the dark theme.

[sorentwo]

Here's another example with the admonition in dark mode. Aside from it being really bright, the link (at the end) lacks contrast.

I realize there's a feedback cycle underway with a designer and I wanted to add this for consideration. If you'd prefer a short-term fix for the link contrast, I'm happy to submit one.

[josevalim]

I fixed links (sorry, I saw your edit just now). I have already asked the designer, I will open up a new issue once I have the new mockups. :)