Include page titles in autocomplete (#1537)

Author: ByeongUkChoi

assets/js/autocomplete/suggestions.js

@@ -15,7 +15,8 @@ import { escapeRegexModifiers, escapeHtmlEntities, isBlank } from '../helpers'
 const SUGGESTION_CATEGORY = {
   module: 'module',
   moduleChild: 'module-child',
-  mixTask: 'mix-task'
+  mixTask: 'mix-task',
+  extra: 'extra'
 }
 
 /**
@@ -35,7 +36,8 @@ export function getSuggestions (query, limit = 5) {
   const suggestions = [
     ...findSuggestionsInTopLevelNodes(nodes.modules, query, SUGGESTION_CATEGORY.module),
     ...findSuggestionsInChildNodes(nodes.modules, query, SUGGESTION_CATEGORY.moduleChild),
-    ...findSuggestionsInTopLevelNodes(nodes.tasks, query, SUGGESTION_CATEGORY.mixTask)
+    ...findSuggestionsInTopLevelNodes(nodes.tasks, query, SUGGESTION_CATEGORY.mixTask),
+    ...findSuggestionsInTopLevelNodes(nodes.extras, query, SUGGESTION_CATEGORY.extra)
   ]
 
   return sort(suggestions).slice(0, limit)

assets/test/autocomplete/suggestions.spec.js

@@ -59,10 +59,11 @@ describe('getSuggestions', () => {
   })
 
   describe('find', () => {
-    it('returns matching modules, tasks and exceptions', () => {
+    it('returns matching modules, tasks, extras and exceptions', () => {
       expect(getSuggestions('Map').length).to.eql(1)
       expect(getSuggestions('Ecto.Repo').length).to.eql(1)
       expect(getSuggestions('phx.server').length).to.eql(1)
+      expect(getSuggestions('API Reference').length).to.eql(1)
       expect(getSuggestions('My exception').length).to.eql(1)
     })
 
@@ -72,10 +73,6 @@ describe('getSuggestions', () => {
       expect(getSuggestions('has_many').length).to.eql(1)
     })
 
-    it('ignores matching extras', () => {
-      expect(getSuggestions('api-reference').length).to.eql(0)
-    })
-
     it('handles special characters', () => {
       expect(getSuggestions('&&/2').length).to.eql(1)
       expect(getSuggestions('<>').length).to.eql(1)