Simplify tests

Author: josevalim

lib/ex_doc/formatter/html.ex

@@ -387,7 +387,7 @@ defmodule ExDoc.Formatter.HTML do
 
     source_path = input |> Path.relative_to(File.cwd!()) |> String.replace_leading("./", "")
 
-    source_url = Utils.source_url_pattern(source_url_pattern, source_path, "1")
+    source_url = Utils.source_url_pattern(source_url_pattern, source_path, 1)
 
     %{
       id: id,

lib/ex_doc/retriever.ex

@@ -336,7 +336,7 @@ defmodule ExDoc.Retriever do
   defp source_link(%{path: _, url: nil}, _line), do: nil
 
   defp source_link(source, line) do
-    Utils.source_url_pattern(source.url, source.path, to_string(line))
+    Utils.source_url_pattern(source.url, source.path, line)
   end
 
   defp source_path(module, _config) do

lib/ex_doc/utils.ex

@@ -91,15 +91,22 @@ defmodule ExDoc.Utils do
     Integer.to_string(integer)
   end
 
-  def source_url_pattern(source_url_pattern, path, line) do
-    if is_function(source_url_pattern) do
-      source_url_pattern.(path, line)
-    else
-      if url = source_url_pattern do
-        url
+  @doc """
+  Generates a url based on the given pattern.
+  """
+  def source_url_pattern(source_url_pattern, path, line)
+      when is_binary(path) and is_integer(line) do
+    cond do
+      is_function(source_url_pattern) ->
+        source_url_pattern.(path, line)
+
+      source_url_pattern ->
+        source_url_pattern
         |> String.replace("%{path}", path)
-        |> String.replace("%{line}", line)
-      end
+        |> String.replace("%{line}", Integer.to_string(line))
+
+      true ->
+        nil
     end
   end
 end

test/ex_doc/retriever/source_pattern_test.exs

@@ -82,4 +82,9 @@ defmodule ExDoc.UtilsTest do
            }\
            """
   end
+
+  test "source_url_pattern" do
+    assert ExDoc.Utils.source_url_pattern("/%{path}-%{line}", "lib/foo", 13) == "/lib/foo-13"
+    assert ExDoc.Utils.source_url_pattern(&"/#{&1}:#{&2}", "lib/foo", 13) == "/lib/foo:13"
+  end
 end