Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "PUT /objects/{object_id}" #24

Closed
3 tasks
uniqueg opened this issue Oct 5, 2020 · 0 comments · Fixed by #31
Closed
3 tasks

Implement "PUT /objects/{object_id}" #24

uniqueg opened this issue Oct 5, 2020 · 0 comments · Fixed by #31
Labels
flag: good 1st issue Good for newcomers priority: medium Medium priority type: feature New feature or request type flag: spec change Proposed change requires spec changes workload: hours Likely takes hours to resolve

Comments

@uniqueg
Copy link
Member

uniqueg commented Oct 5, 2020

Description

Currently, there are only POST and DELETE endpoints for registering/indexing and removing objects, respectively. However, this presents a user from choosing their own identifier during registration and also makes it impossible to update any given object. While DRS objects are generally meant to be permanent, and so updating an object is not required, in some situations, e.g., when registering objects that are inherently temporary, such functionality would be desirable.

Proposed solution

  • Add a PUT /objects/{object_id} endpoint to the DRS-Filer custom OpenAPI specification here; an example for a PUT endpoint definition can be found in the TRS-Filer repository
  • Modify the existing controller for POST /objects so that it supports PUTting objects as well; an example for how the same controller is used for both POSTing and PUTting resources can be found in the TRS-Filer repository
  • Add/update the necessary unit tests
@uniqueg uniqueg added flag: good 1st issue Good for newcomers priority: medium Medium priority type flag: spec change Proposed change requires spec changes type: feature New feature or request workload: hours Likely takes hours to resolve Hacktoberfest Hacktoberfest Suggested issue for https://hacktoberfest.digitalocean.com/ labels Oct 5, 2020
@uniqueg uniqueg changed the title Implement "PUT /objects/{id}" Implement "PUT /objects/{object_id}" Oct 5, 2020
@sarthakgupta072 sarthakgupta072 removed the Hacktoberfest Hacktoberfest Suggested issue for https://hacktoberfest.digitalocean.com/ label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: good 1st issue Good for newcomers priority: medium Medium priority type: feature New feature or request type flag: spec change Proposed change requires spec changes workload: hours Likely takes hours to resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants