Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headerbar color demo doesn't work #556

Closed
danirabbit opened this issue Jan 7, 2022 · 2 comments · Fixed by #557
Closed

Headerbar color demo doesn't work #556

danirabbit opened this issue Jan 7, 2022 · 2 comments · Fixed by #557

Comments

@danirabbit
Copy link
Member

What Happened?

Since porting to GTK4, the demo for changing headerbar color doesn't seem to have any effect

Steps to Reproduce

Set a custom headerbar color on the "Style Classes" page and notice it doesn't change

Expected Behavior

Headerbar color should change

OS Version

7.x (Early Access)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

@davidmhewitt
Copy link
Member

Yes, this is one of my known regressions from #542

I noted:

Need to fix Granite.Widgets.Utils.set_color_primary

I think it was using deprecated APIs internally, and will possibly depend on how we want to do this in the stylesheet? So I just commented it out.

@danirabbit
Copy link
Member Author

Yeah I just wanted to make sure I was tracking these things somewhere I won't forget to follow up on it :)

Repository owner moved this from Todo to Done in GTK4 Porting Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants