Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM can be set to an event that is not in the room specified #4257

Open
lukebarnard1 opened this issue Jun 9, 2017 · 4 comments
Open

RM can be set to an event that is not in the room specified #4257

lukebarnard1 opened this issue Jun 9, 2017 · 4 comments
Labels
A-Read-Marker Green line showing how far _you_ have read O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jun 9, 2017 •
edited
Loading

We never validate that the event marked by the RM is actually in the room specified. If a client has a bug, it might set a RM for one room that it meant to set for another. In Riot's case the RM would never be displayed and the "Jump to first unread..." would give you a lovely "Failed to load timeline position".
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P3 labels Jun 20, 2017
@lampholder
Copy link
Member

Setting this as p3 minor due to the currently low likelihood of this striking.

@turt2live
Copy link
Member

Could this be caused by switching rooms quickly? I've been having disappearing markers, but unable to find a reliable case. If my issue is a different one, I'll gladly open a new issue :)

@lukebarnard1
Copy link
Contributor Author

😬 possibly, @turt2live

@afranke afranke added the A-Read-Marker Green line showing how far _you_ have read label Aug 25, 2021
@MadLittleMods MadLittleMods mentioned this issue Feb 5, 2022
Open
@MadLittleMods
Copy link
Contributor

MadLittleMods commented Feb 5, 2022 •
edited
Loading

Related to #20927 (got a reproduction with the "Jump to first unread message." arrow instead)

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P3 labels Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Read-Marker Green line showing how far _you_ have read O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@afranke @MadLittleMods @turt2live @lampholder @lukebarnard1 @SimonBrandner