Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting 'join' on a room in a space directory doesn't switch you to the room. #20867

Open
ara4n opened this issue Feb 2, 2022 · 3 comments
Open

Hitting 'join' on a room in a space directory doesn't switch you to the room. #20867

ara4n opened this issue Feb 2, 2022 · 3 comments
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design

Comments

@ara4n
Copy link
Member

ara4n commented Feb 2, 2022

Steps to reproduce

  1. Join a space (e.g. #fsfe:fsfe.org in this instance)
  2. Click the join button on the suggested https://matrix.to/#/#community:fsfe.org room

Outcome

What did you expect?

To join the room

What happened instead?

Instead, there's a pause, and the button then turns into a 'View' button.
You then have to click the 'View' button to actually join the room you just asked to join.

c'est une WTF.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

nightly

Homeserver

matrix.org

Will you send logs?

No
@ara4n ara4n added the T-Defect label Feb 2, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 2, 2022 •
edited
Loading

This was done by user demand, as they were sick of having to go back and forth when joining many rooms. Especially if they just joined a room really far down the list, and wanted to join another one next to it, having to wait for pagination/scroll/filter would have been more annoying.

@t3chguy t3chguy added A-Spaces Spaces, groups, communities X-Needs-Design labels Feb 2, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 2, 2022

matrix-org/matrix-react-sdk@27e1636 was the change

#17388 was the original issue, the Join->Spinner->View interaction was suggested by @niquewoodhouse in a DM

@dbkr
Copy link
Member

dbkr commented Feb 2, 2022

presumably the point being that it does actually join it, but doesn't take you to the new room?

@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 2, 2022
@t3chguy t3chguy changed the title Hitting 'join' on a room in a space directory doesn't join you to the room. Hitting 'join' on a room in a space directory doesn't switch you to the room. Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbkr @ara4n @t3chguy