Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stickers in sticker picker aren't cached #2066

Closed
Bubu opened this issue Sep 5, 2020 · 4 comments
Closed

Stickers in sticker picker aren't cached #2066

Bubu opened this issue Sep 5, 2020 · 4 comments

Comments

@Bubu
Copy link
Contributor

Bubu commented Sep 5, 2020

Describe the bug
The stickers (well, I guess images) displayed in the sticker picker aren't cached. Which leads to element android not shwoing any stickers on bad/missing internet connection. And I guess it's redownloading about 10MB of sticker data whenever I want to sent a sticker.

This is using https://github.com/maunium/stickerpicker as a stickerpicker

To Reproduce
Steps to reproduce the behavior:

  1. Have https://github.com/maunium/stickerpicker as a stickerpicker
  2. Open the stickerpicker, wait for all previews to be downloaded
  3. close element android
  4. open stickerpicker again and wait for everything to download again

Expected behavior
I expected that the stickerpicker widget itself and the sticker preview data is cached

Smartphone (please complete the following information):

  • Device: Nexus 5X
  • OS: Android 8.1

Additional context

  • App version 1.0.5-F-Droid
  • Homeserver: bubu1.eu
@Bubu
Copy link
Contributor Author

Bubu commented Sep 5, 2020

Mmmh, maybe there is some caching. Stickers load faster sometimes. But they definitely don't load at all when you are offline.

@dkanada
Copy link
Contributor

dkanada commented Jan 6, 2021

I can confirm there is zero caching. I found the code that disables all caching for widgets and removed it for my personal builds to make stickers viable. Hopefully I'll have a PR to fix that along with a few more sticker issues soon.

@kojid0
Copy link
Contributor

kojid0 commented Jan 9, 2021

I can confirm there is zero caching. I found the code that disables all caching for widgets and removed it for my personal builds to make stickers viable. Hopefully I'll have a PR to fix that along with a few more sticker issues soon.

Thank you!

@bmarty
Copy link
Member

bmarty commented Aug 23, 2021

Done in #2648 (Element Android 1.2.1)

@bmarty bmarty closed this as completed Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants