-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add doc link in help menu on more ML pages #86500
Conversation
Pinging @elastic/ml-ui (:ml) |
@elasticmachine merge upstream |
@@ -130,6 +135,7 @@ export const Page: FC = () => { | |||
</EuiPageContent> | |||
</EuiPageBody> | |||
</EuiPage> | |||
<HelpMenu docLink={helpLink} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be better if we add the HelpMenu
link into all the ML pages in one single PR. Otherwise if you switch to a page where it isn't explicitly set like this, it will remain pointing to the last configured link. For example, here on the Data Visualizer page the link will open up https://www.elastic.co/guide/en/machine-learning/master/ml-dfanalytics.html as the Data Visualizer page doesn't contain its own HelpMenu
tag.
https://www.elastic.co/guide/en/machine-learning/master/ml-dfanalytics.html
From a quick look, I think you need to set it on all the pages which contain NavigationMenu
, which would be:
./access_denied/page.tsx
./datavisualizer/datavisualizer_selector.tsx
./datavisualizer/file_based/file_datavisualizer.tsx
./datavisualizer/index_based/page.tsx
./data_frame_analytics/pages/analytics_exploration/page.tsx
./data_frame_analytics/pages/analytics_management/page.tsx
./explorer/explorer.js
./jobs/jobs_list/jobs.tsx
./overview/overview_page.tsx
./settings/calendars/edit/new_calendar.js
./settings/calendars/list/calendars_list.js
./settings/filter_lists/edit/edit_filter_list.js
./settings/filter_lists/list/filter_lists.js
./settings/settings.tsx
./timeseriesexplorer/timeseriesexplorer_page.tsx
@elasticmachine merge upstream |
x-pack/plugins/ml/public/application/settings/calendars/edit/new_calendar.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/settings/filter_lists/edit/edit_filter_list.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/settings/filter_lists/list/filter_lists.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/settings/calendars/list/calendars_list.js
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest edits LGTM
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
Summary
Related to #85088
This PR adds documentation links in the help menu on all of the pages in the Machine Learning app that contain a
NavigationMenu
. For example: