Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] File upload enable consistent-type-imports eslint rule #212044

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ML] File upload enable consistent-type-imports eslint rule #212044

wants to merge 3 commits into from

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 21, 2025 •
edited
Loading

Enabling consistent-type-imports rule and running node scripts/eslint --no-cache --fix to fix every type import.

Every other ML owned plugin has this rule enabled. Originally added in #176921

@jgowdyelastic jgowdyelastic self-assigned this Feb 21, 2025
@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer Feature:File Upload backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 21, 2025
@jgowdyelastic jgowdyelastic marked this pull request as ready for review February 21, 2025 11:20
@jgowdyelastic jgowdyelastic requested review from a team as code owners February 21, 2025 11:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Feb 21, 2025
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @jgowdyelastic

qn895
qn895 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

nreese
nreese approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only

peteharverson
peteharverson approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@jbudz jbudz jbudz approved these changes

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:version Backport to applied version labels Feature:File and Index Data Viz ML file and index data visualizer Feature:File Upload :ml release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @nreese @jbudz @peteharverson @qn895