Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URLs from ui_settings.ts to doc link service #122408

Merged
merged 7 commits into from
Jan 11, 2022
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 6, 2022

Summary

Adds URLs from https://github.com/elastic/kibana/blob/main/src/plugins/data/server/ui_settings.ts and https://github.com/elastic/kibana/blob/main/src/plugins/discover/server/ui_settings.ts to the doc link service.

It also edits the existing links.kibana value so that it's "links.kibana.guide" like the other books' index.html links

Relates to #88107

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 6, 2022
@lcawl lcawl requested a review from a team as a code owner January 6, 2022 00:30
@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2022

@elasticmachine merge upstream

@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaOverview 10.3KB 10.3KB +6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 290.8KB 291.1KB +383.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 11, 2022
@lcawl lcawl merged commit 55b8c80 into elastic:main Jan 11, 2022
@lcawl lcawl deleted the settings-links branch January 11, 2022 01:12
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.0 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 122408

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants