[8.0] [UA] - Add warning to accept for reindex #122249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
backport
v8.0.0
Team:Kibana Management
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
sebelga
approved these changes
Jan 10, 2022
| @@ -123,7 +123,10 @@ export default function ({ getService }) { | |||
|
|
|||
| it('shows no warnings', async () => { | |||
| const resp = await supertest.get(`/api/upgrade_assistant/reindex/7.0-data`); | |||
| expect(resp.body.warnings.length).to.be(0); | |||
| // By default all reindexing operations will replace an index with an alias (with the same name) | |||
There was a problem hiding this comment.
I wonder if this shows no warnings test shouldn't be also in 7.17?
There was a problem hiding this comment.
Yeah I guess we could have a similar test there, I'll see if I can add it in a subsequent PR!
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 11, 2022
* [UA] Inform user about changes to reindexed data * commit using @elastic.co * Fix linter issues * Fix integration test Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d0cf489)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Jan 11, 2022
* [UA] Inform user about changes to reindexed data * commit using @elastic.co * Fix linter issues * Fix integration test Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sabarasaba
added a commit
that referenced
this pull request
Jan 11, 2022
* [8.0] [UA] - Add warning to accept for reindex (#122249) * [UA] Inform user about changes to reindexed data * commit using @elastic.co * Fix linter issues * Fix integration test Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fix linter issue Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.0: