Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY axis] Give the ability to change the colors opacity #97226

Closed
stratoula opened this issue Apr 15, 2021 · 7 comments · Fixed by #100453
Closed

[XY axis] Give the ability to change the colors opacity #97226

stratoula opened this issue Apr 15, 2021 · 7 comments · Fixed by #100453
Assignees
Labels
discuss enhancement New value added to drive a business result Feature:XYAxis XY-Axis charts (bar, area, line) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Apr 15, 2021

Describe the feature:
Right now the XY axis coloring works with the default opacity. We received feedback from our users that they prefer the styling of the vislib implementation which doesn't add an opacity to the colors. As a result on a dark background is easier to read:

XY Axis:
image

Vislib:
image

I suggest to add a new setting to the xy axis charts editor to adjust the colors opacity (TSVB already offers this ability)

It could be either a num input or a slider. Whatever suits better.

@stratoula stratoula added the Feature:XYAxis XY-Axis charts (bar, area, line) label Apr 15, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 15, 2021
@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 15, 2021
@stratoula
Copy link
Contributor Author

stratoula commented Apr 15, 2021

Another thing that @markov00 has mentioned and I agree are the dots that are quite big and confusing.
@elastic/kibana-design we want your input on this. Wdyt? As we want to remove the vislib implementation in the future, I think we should address this.

@stratoula stratoula added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. discuss labels Apr 15, 2021
@ryankeairns
Copy link
Contributor

Hey @stratoula ,

Another thing that @markov00 has mentioned and I agree are the dots that are quite big and confusing.
@elastic/kibana-design we want your input on this. Wdyt? As we want to remove the vislib implementation in the future, I think we should address this.

+1 for providing options. To that point, could the dots also be an option or have a size setting?

@stratoula
Copy link
Contributor Author

stratoula commented Apr 20, 2021

@ryankeairns I think that we can only show/hide the dots but I ping @markov00 to confirm.
Update: I discussed it with Marco and yes we can also adjust the size!

@markov00
Copy link
Member

Exactly, you can change the radius, fill, stroke of them, all at once or individually (as in the bubble-chart: you can test this on current visualize, hiding the line of a line chart and adding a metric for the dot size)
Please double check what happen with ophan data points (data points that doesn't have continuity with a previous and a next point)

We can also define a global policy to show points only under specific circumstances (just random numbers not valid ones):

  • only if the data points are less then 10
  • only if the chart is bigger then 100x50 px
  • only if rendering 2 series
  • only for line series

@stratoula
Copy link
Contributor Author

There is something else we should also take under consideration. Here is a Lens and an XY visualization that depict exactly the same series
image

In Lens there are no data points, while on XY axis there are. Opacity is the same (the default). I think that these two types of visualizations should be the same because in the future we want to prompt our users to use Lens instead. And the transaction from vislib to xy axis showed us that the different styling can cause confusion to our users.

Same about opacity, it seems that there are users that want to be able to adjust it. What I want to say is that we should apply this feedback having also in mind Lens. So for example, I don't want to give the users the ability to change the opacity to XY axis but Lens doesn't do it.

cc @flash1293 @timroes

@flash1293
Copy link
Contributor

From my perspective it would be great to add this feature to Visualize and Lens.

It would be a nice addition to the "series color" setting we already have:
Screenshot 2021-04-21 at 13 27 22

cc @ghudgins @MichaelMarcialis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:XYAxis XY-Axis charts (bar, area, line) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants