Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Correlations: The error rate correlations color is not consistent with other usage #97097

Closed
formgeist opened this issue Apr 14, 2021 · 1 comment · Fixed by #103500
Closed

[APM] Correlations: The error rate correlations color is not consistent with other usage #97097

formgeist opened this issue Apr 14, 2021 · 1 comment · Fixed by #103500
Assignees
@dgieselaar
Labels
apm:correlations bug Fixes for quality problems that affect the customer experience low hanging fruit DO NOT USE. Use `good first issue` instead Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.0.0

Comments

@formgeist
Copy link
Contributor

Kibana version: 7.12+

Summary

I realized that I imagine since we hide the traffic correlations view, the visualization somehow got mixed up, since the error rate visualization is using the traffic viz color rather than the error rate color to make it consistent with error rate on the service overview and elsewhere.

Screenshot 2021-04-14 at 13 26 13

Currently used color on the error rate correlations visualization

Screenshot 2021-04-14 at 13 26 28

Error rate viz on the Service overview
@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.0.0 apm:correlations labels Apr 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added [zube]: 7.13 low hanging fruit DO NOT USE. Use `good first issue` instead labels Apr 14, 2021
@sorenlouv sorenlouv changed the title [APM] Correlations: The error rate correlations visualization is not consistent with other usage [APM] Correlations: The error rate correlations color is not consistent with other usage Apr 19, 2021
@zube zube bot added [zube]: 7.14 and removed [zube]: 7.14 labels Jun 23, 2021
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Jun 28, 2021
@dgieselaar
[APM] use conventional error rate color for correlations
5470f48 
Closes elastic#97097.
@dgieselaar dgieselaar mentioned this issue Jun 28, 2021
Merged
@zube zube bot closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
apm:correlations bug Fixes for quality problems that affect the customer experience low hanging fruit DO NOT USE. Use `good first issue` instead Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] use conventional error rate color for correlations dgieselaar/kibana
6 participants
@smith @graphaelli @sorenlouv @dgieselaar @formgeist @elasticmachine