[Emotion] Memoize styles + opinionated clean up more components #8172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ remove unnecessary function for styles w/ no theme token + inline JSX where possible
- disabled opacity is fairly static and can be DRYed out - loading spinner: no styles being applied so this isn't necessary
+ remove passed `layout` arg in favor of static definitions - rewrite vertical vs horizontal gutters utils to be slightly less confusing + replace `calc()` with `mathWithUnits()`
+ prefer inline JSX
+ rerun VRT to confirm no regressions. changes are minute/from font aliasing
- replace `EuiHideFor/ShowFor` usage with a breakpoint hook instead
+ remove unnecessary fragments + remove some unnecessary callback consts, just inline them if they're not reused and we're not going to memoize them
- `list_group_item` has too much conditional JSX to deal with right now, should likely be split up into subcomponents in the future + remove unnecessary style functions, just use a static obj instead + re-run VRT screenshots
+ reduce # of style fns for horizontal steps, and remove unnecessary onClick fn in favor of just inlining it (if we're not reusing or memoizing it) + update VRT
- instead of another div and repeated CSS, just use `> *` (which has zero specificity and is very overrideable) to bump the icon/avatar above the vertical line + inline `iconRender` and `ariaLabel`, it's not reused and not particularly increasing readability by being a const
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error. |
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
github-actions
bot
added
community contribution
and removed
stale-pr-closed
stale-pr
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #7561
TODO: probably split this up to 2 PRs
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles