Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent V2: Check that a stream ID exists before generating an add_fields processor for it #33168

Closed
Tracked by #836
cmacknz opened this issue Sep 22, 2022 · 2 comments · Fixed by #33335
Closed
Tracked by #836
Assignees
Labels

Comments

@cmacknz
Copy link
Member

cmacknz commented Sep 22, 2022

In the feature-arch-v2 branch we automatically add a processor to inject the stream ID from the agent policy as event metdata, but we don't check if the stream ID exists before doing this. We should include a check for an empty stream ID before adding the processor.

This is the relevant code in the feature-arch-v2 branch:

// source stream
streamID := streamExpected.GetId()
sourceStream := generateAddFieldsProcessor(mapstr.M{"stream_id": streamID}, "@metadata")
processors = append(processors, sourceStream)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 22, 2022
@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 22, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 22, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@jlind23 jlind23 linked a pull request Oct 13, 2022 that will close this issue
3 tasks
@jlind23
Copy link
Collaborator

jlind23 commented Oct 14, 2022

Closing this per #33335 merge

@jlind23 jlind23 closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants