Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp objects should be updated during the game if they have destructables on them #109

Closed
spudde123 opened this issue Dec 22, 2020 · 0 comments

Comments

@spudde123
Copy link
Collaborator

Some ramp objects may be faulty coming from burnysc2 right now if they have destructables like rocks or small mineral patches on them. Completely blocked ramps don't necessarily even register as ramps, and partly blocked ones can have faulty top_center and bottom_center values and the estimated ramp orientation ends up being incorrect. The commit below fixes this on the map analyzer side by removing destructables first and then redoing the ramp calculation.

spudde123@a8ad54a

The final issue is that now the ramp sides are set to the width without the destructables. Some field in the ramps should be updated during the game to reflect whether the destructables are still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants