Skip to content

Commit 87a88da

Browse files
authored
Towards support File access on Scala Native (#349)
* Move PlatfromThread to JVM and update comments * Add an impl object * Remove impl and celanup docs
1 parent a8d6495 commit 87a88da

File tree

11 files changed

+20
-11
lines changed

11 files changed

+20
-11
lines changed

sconfig/js/src/main/scala/PlatformClassLoader.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import java.net.URL
44
import java.{util => ju}
55

66
/**
7-
* To workaround missing implementation in Scala.js
7+
* To workaround missing implementations
88
*/
99
class PlatformClassLoader(cl: ClassLoader) extends ClassLoaderLike {
1010
def getResources(name: String): ju.Enumeration[URL] = ???

sconfig/js/src/main/scala/PlatformThread.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.ekrich.config.impl
22

33
/**
4-
* To workaround missing implementation in Scala.js
4+
* To workaround missing implementations
55
*/
66
class PlatformThread(thread: Thread) extends ThreadLike {
77
def getContextClassLoader(): ClassLoader = ???

sconfig/js/src/main/scala/PlatformUri.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package org.ekrich.config.impl
33
import java.net.{URI, URL}
44

55
/**
6-
* To workaround missing implementation in Scala.js
6+
* To workaround missing implementations
77
*/
88
class PlatformUri(uri: URI) extends UriLike {
99
def toURL(): URL = ???

sconfig/jvm-native/src/main/scala/PlatformClassLoader.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import java.net.URL
44
import java.{util => ju}
55

66
/**
7-
* To workaround missing implementation in Scala.js
7+
* To workaround missing implementations
88
*/
99
class PlatformClassLoader(cl: ClassLoader) extends ClassLoaderLike {
1010
def getResources(name: String): ju.Enumeration[URL] = cl.getResources(name)

sconfig/jvm-native/src/main/scala/PlatformUri.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package org.ekrich.config.impl
33
import java.net.{URI, URL}
44

55
/**
6-
* To workaround missing implementation in Scala.js
6+
* To workaround missing implementations
77
*/
88
class PlatformUri(uri: URI) extends UriLike {
99
def toURL(): URL = uri.toURL()

sconfig/jvm-native/src/main/scala/PlatformThread.scala sconfig/jvm/src/main/scala/PlatformThread.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.ekrich.config.impl
22

33
/**
4-
* To workaround missing implementation in Scala.js
4+
* To workaround missing implementations in Scala.js and Scala Native
55
*/
66
class PlatformThread(thread: Thread) extends ThreadLike {
77
def getContextClassLoader(): ClassLoader = thread.getContextClassLoader()
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package org.ekrich.config.impl
2+
3+
/**
4+
* To workaround missing implementations
5+
*/
6+
class PlatformThread(thread: Thread) extends ThreadLike {
7+
def getContextClassLoader(): ClassLoader = ???
8+
}

sconfig/shared/src/main/scala/ClassLoaderLike.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import java.net.URL
44
import java.{util => ju}
55

66
/**
7-
* To workaround missing implementation in Scala.js
7+
* To workaround missing implementations in Scala.js and Scala Native
88
*/
99
trait ClassLoaderLike {
1010
def getResources(name: String): ju.Enumeration[URL]

sconfig/shared/src/main/scala/ThreadLike.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.ekrich.config.impl
22

33
/**
4-
* To workaround missing implementation in Scala.js
4+
* To workaround missing implementations in Scala.js and Scala Native
55
*/
66
trait ThreadLike {
77
def getContextClassLoader(): ClassLoader

sconfig/shared/src/main/scala/UriLike.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package org.ekrich.config.impl
33
import java.net.URL
44

55
/**
6-
* To workaround missing implementation in Scala.js
6+
* To workaround missing implementations in Scala.js and Scala Native
77
*/
88
trait UriLike {
99
def toURL(): URL

sconfig/shared/src/main/scala/org/ekrich/config/ConfigFactory.scala

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33
*/
44
package org.ekrich.config
55

6-
import org.ekrich.config.impl.ConfigImpl
7-
import org.ekrich.config.impl.Parseable
86
import java.io.{File, Reader}
97
import java.net.URL
108
import java.{util => ju}
119
import java.util.Properties
1210
import java.util.concurrent.Callable
1311

12+
import org.ekrich.config.impl.ConfigImpl
13+
import org.ekrich.config.impl.Parseable
14+
1415
/**
1516
* Contains static methods for creating [[Config]] instances.
1617
*

0 commit comments

Comments
 (0)