Fix and enhance error logging #1743

michaelortmann · 2025-01-20T12:37:54Z

Found by: tuvok81
Patch by: michaelortmann
Fixes: #1742

One-line summary:

Additional description (if needed):
if .oidentd.conf doesnt exist (yet), eggdrop will create it. This case is not an error and should not be logged as one.

Also save (and restore) errno before check_tcl_event(ident): check_tcl_event(ident) for not loosing errno set by connect():

eggdrop/src/net.c

Line 574 in 0f5599e

rc = connect(sock, &addr->addr.sa, addr->addrlen);

Test cases demonstrating functionality (if applicable):

loadmodule ident
set ident-method 0

Before:

rm ~/.oidentd.conf
$ ./eggdrop -t BotA.conf
[...]
[14:11:46] net: open_telnet_raw(): idx 4 host 127.0.0.1 ip 127.0.0.1 port 6697 ssl 1
[14:11:46] IDENT: oident.conf missing, or error opening for reading
[14:11:46] Failed connect to 127.0.0.1 (No such file or directory)

After:

rm ~/.oidentd.conf
$ ./eggdrop -t BotA.conf
[...]
[14:12:32] net: open_telnet_raw(): idx 4 host 127.0.0.1 ip 127.0.0.1 port 6697 ssl 1
[14:12:32] net: attempted socket connection refused: 127.0.0.1:6697
[14:12:32] Failed connect to 127.0.0.1 (Connection refused)

michaelortmann added 2 commits January 20, 2025 13:31

Enhance error logging

31b1d64

Save (and restore) errno before check_tcl_event(ident)

a2b07c9

michaelortmann changed the title ~~(WIP) Enhance error logging~~ Enhance error logging Jan 20, 2025

michaelortmann changed the title ~~Enhance error logging~~ Fix and enhance error logging Jan 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and enhance error logging #1743

Fix and enhance error logging #1743

michaelortmann commented Jan 20, 2025 •

edited

Loading

Fix and enhance error logging #1743

Are you sure you want to change the base?

Fix and enhance error logging #1743

Conversation

michaelortmann commented Jan 20, 2025 • edited Loading

michaelortmann commented Jan 20, 2025 •

edited

Loading