-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: load balancer and registry authentication #1316
Conversation
I need to fix the publish job and I also noticed that there's some more content I need to add. Converting to draft for now, will let you know when I'm ready. |
3095a2f
to
ba8fe86
Compare
ba8fe86
to
625de51
Compare
|
625de51
to
581321d
Compare
@m1ghtym0 ready for review! |
On bare metal, images are pulled within the confidential guest, which doesn't receive credentials from the host yet. | ||
You can work around this by mirroring the required images to a private registry that's only exposed to the cluster. | ||
Such a registry needs to have a valid TLS certificate that's trusted in the web PKI (issued by Let's Encrypt, for example). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this description, you need to already know what you're doing, but if you build a bare-metal setup, that's a fair assumption. So that's fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have an example deployment for this, do you think it's worth adding here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one the one hand this is only related content that's not directly connected to Contrast and having such example means we would need to maintain and ideally test it.
On the other hand, that would definitely be a good starting point for folks setting up a bare-metal deployment. Could be part of the examples section.
Depending if your verdict if such example would be maintainable, I'd say why not adding it to the examples section?:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can/Should be done independently of this PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure which examples section you're referring to. I lean towards adding some yaml I've written for a demo right here, but I don't think this should be a maintained feature - we should rather invest that energy into making registry authentication work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was expecting this to be quite a lot of yaml. Hence the thought of an individual page in the Contrast examples section. If it works inline, of course, as you say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed privately, won't add the example because it's too lengthy.
Add some missing details with respect to load balancers and registry authentication.
I have some more content for the
How-To
section in mind: