Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min_recommended_version for eccodes #82

Closed
zklaus opened this issue Sep 1, 2023 · 3 comments
Closed

Update min_recommended_version for eccodes #82

zklaus opened this issue Sep 1, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@zklaus
Copy link

zklaus commented Sep 1, 2023

What happened?

Version 1.6.0 added codes_bufr_key_is_coordinate in 880855c.

This was added to Eccodes only in version 2.31.0, c.f. ECC-1611.

Consequently, the min_recommended_version should be updated in

min_recommended_version_str = "2.21.0"

With older versions installed, we get runtime linker errors such as

ImportError: /opt/conda/envs/esmvaltool/lib/python3.11/site-packages/gribapi/_bindings.cpython-311-x86_64-linux-gnu.so: undefined symbol: codes_bufr_key_is_coordinate

What are the steps to reproduce the bug?

  • Install eccodes-python-1.6.0 with any version of eccodes<2.31.0 (>=2.21.0 according to min_recommended_version)
  • import gribapi

Version

v1.6.0

Platform (OS and architecture)

Linux

Relevant log output

No response

Accompanying data

No response

Organisation

No response

@zklaus zklaus added the bug Something isn't working label Sep 1, 2023
@shahramn shahramn self-assigned this Sep 1, 2023
@shahramn
Copy link
Collaborator

shahramn commented Sep 21, 2023

We do have some GitHub actions which use the ecCodes library as old as 2.27.0 and all the tests pass.
No errors on import
For example see https://github.com/ecmwf/eccodes-python/actions/runs/6235294400/job/16924240979

@zklaus
Copy link
Author

zklaus commented Sep 21, 2023

Thanks for following up. Which test imports gribapi? I could not find any.

Note that it is the minimum recommended version for gribapi (after all, it is in gribapi/__init__.py) and that the error shows up when you do import gribapi (c.f. "[...] steps to reproduce [...]" above).

@shahramn
Copy link
Collaborator

OK I will update the minimum recommended version to 2.31.0
Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants