Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A user can drop an entity onto an enum from the vorto repository #666

Closed
aedelmann opened this issue Jun 29, 2017 · 2 comments
Closed

A user can drop an entity onto an enum from the vorto repository #666

aedelmann opened this issue Jun 29, 2017 · 2 comments
Labels
Milestone

Comments

@aedelmann
Copy link
Contributor

  1. Create enum in eclipse toolset
  2. search for entity in model repository
  3. Drag and Drop entity on enum

Expected: Error pops up saying "Entities cannot be dropped onto an Enum"
Actual: Entity is imported into enum

@erlemantos
Copy link
Contributor

How about this behaviour?

  • If a user drops "Model A" from the Repository to any "Model B", "Model A" is ADDED to the project (copied from the Repo). A Reference (using ...) is also added to "Model B" if it legally makes sense.

For example:

  • If a user drops "Enum A" from the Repo to "Entity B" in the workspace, "Enum A" is copied to the project, and a Reference is added to "Enum A" in "Entity B".
  • If a user drops "Entity A" from the Repo to "Enum B" in the workspace, "Entity A" is copied to the project, but a Reference to "Entity A" is NOT added to "Enum B" because it doesn't make sense and illegal.

Same applies to function blocks and information models.

Justification:

  • Most likely, if a user drags and drops an Entity towards an Enum, the intention might have been to add the Entity to the Project

@aedelmann
Copy link
Contributor Author

@erlemantos
Sounds good :)

erlemantos pushed a commit to bosch-io/vorto that referenced this issue Jul 7, 2017
Signed-off-by: Erle Czar Mantos <erleczar.mantos@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants