Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#83 Update to Theia 1.18.0 and support Codicons #85

Merged
merged 2 commits into from
Oct 18, 2021
Merged

#83 Update to Theia 1.18.0 and support Codicons #85

merged 2 commits into from
Oct 18, 2021

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Oct 18, 2021 •
edited
Loading

Fixes #83

  • Update Theia to 1.18.0
  • Update Jenkinsfile to use eclipsetheia/theia-blueprint docker image to be able to build Theia >=1.15.0 (which requires libsecret-1-dev)
  • Update sprotty to latest version
  • Use Codicons instead of FontAwesome icons

@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2021

@ndoschek ndoschek mentioned this pull request Oct 18, 2021
Closed
@ndoschek @tortmayr
#83 Update to Theia 1.18.0 and support Codicons
b65ef64 
- Update Theia to 1.18.0
- Update Jenkinsfile to use eclipsetheia/theia-blueprint docker image to be able to build Theia >=1.15.0 (which requires libsecret-1-dev)
- Update sprotty to latest version
- Use Codicons instead of FontAwesome icons
@planger planger self-requested a review October 18, 2021 13:18
planger
planger reviewed Oct 18, 2021
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!
However, as far as I see we break compatability with Theia <1.18, right? So we should mention that in the https://github.com/eclipse/sprotty-theia/blob/master/CHANGELOG.md.
Can you please add that to this PR?

@ndoschek ndoschek mentioned this pull request Oct 18, 2021
Closed
6 tasks
planger
planger approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit fb0f9eb into master Oct 18, 2021
@tortmayr tortmayr deleted the ndoschek/issues/83 branch October 18, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Theia 1.18.0 and support Codicons
3 participants
@tortmayr @planger @ndoschek