Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix commented parts of z_put.py #176

Merged
merged 3 commits into from
Apr 15, 2024
Merged

fix(examples): fix commented parts of z_put.py #176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd35566
fix(examples): fix commented parts of z_put.py
wyfo Apr 5, 2024
89d55d3
fix: apply PR reviews
wyfo Apr 10, 2024
abb91cf
fix: apply PR reviews
wyfo Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/z_put.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import argparse
import json
import zenoh
from zenoh import config, Value, Encoding

# --- Command line argument parsing --- --- --- --- --- ---
parser = argparse.ArgumentParser(
Expand Down Expand Up @@ -87,7 +86,7 @@ def main():
# - Json (str format)
# session.put('demo/example/Json',
# json.dumps(['foo', {'bar': ('baz', None, 1.0, 2)}]).encode(),
# encoding=Encoding.TEXT_JSON)
# encoding=Encoding.TEXT_JSON())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be encoding=zenoh.Encoding.TEXT_JSON() since we remove the import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, I forgot it for the second time...


# - Raw ('application/octet-stream' encoding by default)
# session.put('demo/example/Raw', b'\x48\x69\x21')
Expand Down