Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix z_collections_test #895

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix z_collections_test #895

merged 1 commit into from
Feb 14, 2025

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 12, 2025 •
edited
Loading

Fix int_map_iterator_deletion_test in z_collections_test

@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'enhancement', 'documentation', 'dependencies', 'breaking-change', 'bug', 'new feature', 'internal'}

@sashacmc sashacmc added bug Something isn't working internal Changes not included in the changelog labels Feb 12, 2025
@sashacmc sashacmc marked this pull request as ready for review February 12, 2025 16:25
gmartin82
gmartin82 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@gmartin82 gmartin82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass without segfault with fix applied.

@milyin milyin merged commit 6223029 into eclipse-zenoh:main Feb 14, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmartin82 gmartin82 gmartin82 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashacmc @gmartin82 @milyin