Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include dependency check before release #1818

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bmg13
Copy link
Contributor

@bmg13 bmg13 commented Feb 27, 2025

WHAT

Perform the dependency check before release in main branch instead on all branches in PR targetting main and publish the DEPENDENCIES file to GitHub pages.

WHY

Considering this dependency validation can happen only before release, this is an overhead removed in PRs and additionally provides the dependencies information in GH Pages as well.

FURTHER NOTES

Some reasoning behind the decisions proposed:

  • The creation, validation and publishing of dependencies information is done on three situations: every night, on each new commit in main and by workflow call. This promotes having a valid DEPENDENCIES file, i.e. with no rejected or restricted dependencies, by the time a release is to be done.
  • The preexisting run-dash action in sig-infra is called to promote reusability of this check on other TX repos as well.

Closes #1743

@bmg13 bmg13 marked this pull request as ready for review February 27, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open
Development

Successfully merging this pull request may close these issues.

Get rid of the dependency check
1 participant