launch configs as preferences #4947

akosyakov · 2019-04-18T11:10:00Z

Includes:

launch configurations as preferences
compatibility with VS Code configuration files, fix [vscode] derive theia settings from vscode settings file #2440
- over 800 compatibility tests
~~compound launch configurations~~ i will completely remove it from this PR and Theia UI, should be implemented separately - support compound launch configurations #5008
close Retrieving launch configurations using Plugin API #4743 (superseded), fix Plugin api: theia#workspace#getConfiguration doesn't handle resource argument. #2290

Running VS Code tests:

check out https://github.com/akosyakov/vscode-launch under plugins and build yarn && yarn compile
add the following configuration to launch.json:

    {
      "name": "Launch VS Code Tests",
      "type": "node",
      "request": "launch",
      "args": [
        "${workspaceFolder}/examples/browser/src-gen/backend/main.js",
        "${workspaceFolder}/plugins/vscode-launch/tests",
        "--port",
        "3030",
        "--hostname",
        "0.0.0.0",
        "--extensionTestsPath=${workspaceFolder}/plugins/vscode-launch/out/test",
        "--hosted-plugin-inspect=9339"
      ],
      "env": {
        "THEIA_DEFAULT_PLUGINS": "local-dir:${workspaceFolder}/plugins"
      },
      "stopOnEntry": false,
      "sourceMaps": true,
      "outFiles": [
        "${workspaceFolder}/../.js"
      ]
    }

run the configuration in no debug mode and open browser

TODO:

benoitf · 2019-04-18T11:41:58Z

packages/core/src/common/preferences/preference-scope.ts

@@ -57,7 +57,7 @@ export namespace PreferenceScope {
            case 'application':
                return PreferenceScope.User;
            case 'window':
-                return PreferenceScope.Workspace;
+                return PreferenceScope.Folder;


hello, in which case do we have preferencescope.workpace ?

it is inclusive, i.e folder allows workspace and global

does it mean, users wouldn't be able to define prefs only available at the "workspace" & "user" level?

actually the whole scope is valid check is bogus right now, it should be aligned with:
https://github.com/Microsoft/vscode/blob/750680d2f7ae563529501f8ec419d83ccf8ec325/src/vs/workbench/services/configuration/common/configuration.ts#L23-L26

It is not inclusive, folder preferences allow ONLY resource, workspace preference allow ONLY window and resource level. I will rework it as well.

@elaihau @benoitf Would be fine to fix it with a follow-up PR? otherwise it would be postponed more and it does not seem to relate to referenced issues.

yes it could be resolved in a separate PR. since the next release would be either on Apr 30 or May 1, do we want to hold this one until the release is made?

please ask on Spectrum, if someone has concrete objections, yes

from my side, most important that it should be tested not only by me, but double checked by someone else

benoitf · 2019-04-18T11:49:36Z

I tried this PR + backporting on this branch ed40d90

But I got

peError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at assertPath (path.js:39:11)
    at Object.join (path.js:1152:7)
    at Config.diagramsRoot (/private/var/folders/tg/_5rxbhmj4xncz4szvpgswrmc0000gn/T/vscode-unpacked/jebbs.plantuml-2.10.9.vsix/extension/out/src/plantuml/config.js:67:27)

FYI source code is

diagramsRoot(uri) {
        let folder = uri ? vscode.workspace.getWorkspaceFolder(uri) : undefined;
        if (!folder)
                 return undefined;
LINE67       --> let fsPath = path.join(folder.uri.fsPath, this.read("diagramsRoot", uri));
                 return vscode.Uri.file(fsPath);
    }

and read method is there
https://github.com/qjebbs/vscode-plantuml/blob/master/src/plantuml/configReader.ts#L48-L73

akosyakov · 2019-04-18T15:01:04Z

@benoitf it is WIP, but thanks for the pointer will test it as well

akosyakov · 2019-04-23T12:55:48Z

@elaihau It is not finished, but could you test support of preferences in multi-root workspace context with this PR to catch regressions earlier?

akosyakov · 2019-04-26T14:33:50Z

@elaihau thx for the review, found another bug:

duplicate add and remove actions, it is easy to fix

Fixed https://github.com/theia-ide/theia/pull/4947/files#diff-f9afc1d61ee7ba79952f1f81bdf6bd52

akosyakov · 2019-04-26T14:41:32Z

@elaihau What is the content of testdir i cannot reproduce #4947 (comment)

elaihau · 2019-04-26T14:48:59Z

@elaihau What is the content of testdir i cannot reproduce #4947 (comment)

it has nothing special. the problem can be reproduced with "theia" folder too

elaihau · 2019-04-26T14:54:33Z

btw, i also found this one #5020, but i don't think it is related to this PR

akosyakov · 2019-04-26T14:58:22Z

ok, checking #4947 (comment) then, it should work, it would be a bug if there are no events then a preference provider for settings.json is removed

akosyakov · 2019-04-26T15:29:06Z

@elaihau i don't think it is caused by this PR, events are reported for removed config files, but since these config files don't contain editor.fontSize (it is defined only in workspace settings) then there is no an event for it as well. We could force fire events whenever workspace roots are changed, but maybe it is overkill to cover this corner case?

We actually don't have many tests for events. It would be something worth looking into and align with VS Code expectations as well, but separately.

elaihau · 2019-04-26T15:36:13Z

i am ok with issue mentioned in #4947 (comment) not fixed, as it is really a corner case.

ariel-bentu · 2019-04-26T16:17:46Z

@ariel-bentu please check whether your launch configuration tests are passing with this PR, they do for me

Hi,
I tested it and it works. the only thing is that VSCode allows comments in the launch.json, and when I used comments and used the api to create a new launch configuration - the configuration saved successfully but the comment was gone.

akosyakov · 2019-04-26T16:38:04Z

@ariel-bentu thanks, i will have a look whether it is possible to preserve comments, btw does VS Code do it?

ariel-bentu · 2019-04-26T18:18:49Z

@ariel-bentu thanks, i will have a look whether it is possible to preserve comments, btw does VS Code do it?

I checked and actually, to my surprise, VSCode also looses the comments ... So I guess all is good.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

This allows to re-validate such properties when a corresponding schema has been set. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

…schema `UserLaunchProvider`, `WorkspaceLaunchProvider` and `FoldersLaunchProvider` handle changing of 'launch' section of preferences without paying attention whether configuration is valid or not. Once it happens a new preference schema for launch configurations builds. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov requested review from benoitf and evidolob as code owners April 18, 2019 11:10

benoitf reviewed Apr 18, 2019

View reviewed changes

akosyakov mentioned this pull request Apr 18, 2019

Gaps in vscode-ext support: views, launchConfig #4912

Closed

akosyakov force-pushed the ak/laung_preferences branch 23 times, most recently from 60ec59d to cf9c784 Compare April 23, 2019 12:46

akosyakov force-pushed the ak/laung_preferences branch from 0dd5cd7 to fc65a6e Compare April 26, 2019 14:20

akosyakov force-pushed the ak/laung_preferences branch from fc65a6e to bc14ca1 Compare April 26, 2019 14:47

This was referenced Apr 26, 2019

fix handling of vscode configuration scopes #5021

Open

test configuration event vscode api #5022

Open

akosyakov mentioned this pull request Apr 26, 2019

tasks and launch should be exposed via workspace/workspace folder configurations #4475

Closed

elaihau approved these changes Apr 29, 2019

View reviewed changes

akosyakov mentioned this pull request Apr 29, 2019

[preferences] PreferenceChangeEvent enhancement #5036

Open

akurinnoy and others added 6 commits May 2, 2019 05:41

Added ability to retrieve configuration for a resource.

6db0948

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Handle properties that are not valid at the time of reading.

d4ebb46

This allows to re-validate such properties when a corresponding schema has been set. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Added preference provider to handle 'launch.json'

bb46b37

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

fixes

da6dceb

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

launch preferences support

b9ede94

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov force-pushed the ak/laung_preferences branch from bc14ca1 to b9ede94 Compare May 2, 2019 05:44

akosyakov merged commit aff18c8 into master May 2, 2019

akosyakov deleted the ak/laung_preferences branch May 2, 2019 07:26

This was referenced May 2, 2019

[plug-in][debug]Run/Debug code lenses don't work #4188

Closed

plugins jebbs.plantuml not support #4899

Closed

Plugin User Preferences are ignored #4773

Closed

elaihau mentioned this pull request Apr 23, 2020

[preferences][multi root] Potentially exagerated number of calls to getConfigUri() #7631

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

launch configs as preferences #4947

launch configs as preferences #4947

akosyakov commented Apr 18, 2019 •

edited

Loading

benoitf Apr 18, 2019

akosyakov Apr 18, 2019

elaihau Apr 25, 2019

akosyakov Apr 25, 2019

akosyakov Apr 26, 2019

benoitf Apr 26, 2019

elaihau Apr 26, 2019

akosyakov Apr 26, 2019

benoitf commented Apr 18, 2019

akosyakov commented Apr 18, 2019 •

edited

Loading

akosyakov commented Apr 23, 2019 •

edited

Loading

akosyakov commented Apr 26, 2019 •

edited

Loading

akosyakov commented Apr 26, 2019

elaihau commented Apr 26, 2019

elaihau commented Apr 26, 2019

akosyakov commented Apr 26, 2019

akosyakov commented Apr 26, 2019 •

edited

Loading

elaihau commented Apr 26, 2019

ariel-bentu commented Apr 26, 2019

akosyakov commented Apr 26, 2019

ariel-bentu commented Apr 26, 2019

launch configs as preferences #4947

launch configs as preferences #4947

Conversation

akosyakov commented Apr 18, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoitf commented Apr 18, 2019

akosyakov commented Apr 18, 2019 • edited Loading

akosyakov commented Apr 23, 2019 • edited Loading

akosyakov commented Apr 26, 2019 • edited Loading

akosyakov commented Apr 26, 2019

elaihau commented Apr 26, 2019

elaihau commented Apr 26, 2019

akosyakov commented Apr 26, 2019

akosyakov commented Apr 26, 2019 • edited Loading

elaihau commented Apr 26, 2019

ariel-bentu commented Apr 26, 2019

akosyakov commented Apr 26, 2019

ariel-bentu commented Apr 26, 2019

akosyakov commented Apr 18, 2019 •

edited

Loading

akosyakov commented Apr 18, 2019 •

edited

Loading

akosyakov commented Apr 23, 2019 •

edited

Loading

akosyakov commented Apr 26, 2019 •

edited

Loading

akosyakov commented Apr 26, 2019 •

edited

Loading