Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workspace configuration using API works incorrectly #8991

Closed
RomanNikitenko opened this issue Jan 27, 2021 · 0 comments · Fixed by #8917
Closed

Update Workspace configuration using API works incorrectly #8991

RomanNikitenko opened this issue Jan 27, 2021 · 0 comments · Fixed by #8917
Labels
bug bugs found in the application debug issues that related to debug functionality plug-in system issues related to the plug-in system

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Jan 27, 2021

Bug Description:

I tried to update Workspace launch configurations using API and got incorrect JSON structure in workspace config file.
As result - updated launchconfigurations are not available for running from Debug panel.

You can see my code for testing here
So, I took launch section from workspace config and tried to update configurations section.

Expected:

"launch": {
            "configurations": [
                {
                    "name": "TEST: Attach to Chrome",
                    "port": 9222,
                    "request": "attach",
                    "type": "pwa-chrome",
                    "webRoot": ""
                }
            ]
        }

Actual:

"launch.configurations": [
            {
                "name": "TEST: Attach to Chrome",
                "port": 9222,
                "request": "attach",
                "type": "pwa-chrome",
                "webRoot": ""
            }
        ]

Steps to Reproduce:

  1. Clone my test vs code extension: https://github.com/RomanNikitenko/vscode-test-extension.git
  2. Build it and copy to plugins folder of the theia
  3. Open a multi-root workspace from a config file for testing.
  4. F1 => Test: Update Workspace launch configurations

The command should:

  • add new test Workspace-scoped launch configuration to workspace config file if there is no configurations defined
  • replace existed Workspace-scoped launch configurations by test launch config if there is at least one configuration defined in workspace config file

The new test configuration should be available for running from Debug panel.
But it isn't, as at the moment there is the described bug in theia.

Additional Information

  • Operating System: Fedora 31
  • Theia Version: 4204297
@RomanNikitenko RomanNikitenko added bug bugs found in the application plug-in system issues related to the plug-in system debug issues that related to debug functionality labels Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant