Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal: send \r to submit commands on Windows shells #7509

Closed
paul-marechal opened this issue Apr 6, 2020 · 1 comment
Closed

terminal: send \r to submit commands on Windows shells #7509

paul-marechal opened this issue Apr 6, 2020 · 1 comment
Assignees
@paul-marechal
Labels
bug bugs found in the application debug issues that related to debug functionality process issues related to the process extension terminal issues related to the terminal

Comments

@paul-marechal
Copy link
Member

Description

Follow-up of #6836.

I originally did not understand why in some circumstances I had to send \n twice for commands to be evaluated, but I now realize it is because shells seems to expect \r instead.

Reproduction Steps

See #7141 (comment)

OS and Theia version: Windows 10, Theia 1.0.0
@paul-marechal paul-marechal added bug bugs found in the application terminal issues related to the terminal debug issues that related to debug functionality process issues related to the process extension labels Apr 6, 2020
@paul-marechal paul-marechal self-assigned this Apr 6, 2020
@msujew
Copy link
Member

msujew commented Jun 30, 2023

This has been resolved by #12620.

@msujew msujew closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paul-marechal paul-marechal

Labels
bug bugs found in the application debug issues that related to debug functionality process issues related to the process extension terminal issues related to the terminal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msujew @paul-marechal