Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] prevent merging PRs that are failing CI #6167

Closed
vince-fugnitto opened this issue Sep 11, 2019 · 3 comments
Closed

[CI] prevent merging PRs that are failing CI #6167

vince-fugnitto opened this issue Sep 11, 2019 · 3 comments
Labels
ci issues related to CI / tests proposal feature proposals (potential future features)

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Sep 11, 2019 •
edited
Loading

Description

We should prevent merging PRs that are failing CI.
PRs should not be merged into master when they are breaking CI (ex: #6155)

We can restrict merging PRs that fail:

  • Travis (quite stable and verifies both Linux and macOS)
  • AppVeyor (much more stable than in the past (covers Windows) but perhaps not mandatory).
@vince-fugnitto vince-fugnitto added the ci issues related to CI / tests label Sep 11, 2019
@vince-fugnitto vince-fugnitto mentioned this issue Sep 11, 2019
Merged
@akosyakov
Copy link
Member

akosyakov commented Sep 12, 2019 •
edited
Loading

I'm fine, if we can switch them off to merge something urgent. I won't do it for appveyor, it is very slow. Maybe discuss it first on the dev meeting.

@akosyakov akosyakov added the proposal feature proposals (potential future features) label Sep 12, 2019
@vince-fugnitto
Copy link
Member Author

I think it is no longer a viable option, it would require contacting the webmaster in order to merge PRs which need to be immediate. Am I correct @marcdumais-work ?

@marcdumais-work
Copy link
Contributor

I think it is no longer a viable option, it would require contacting the webmaster in order to merge PRs which need to be immediate. Am I correct @marcdumais-work ?

Yes, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci issues related to CI / tests proposal feature proposals (potential future features)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @marcdumais-work @vince-fugnitto