Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of vscode configuration scopes #5021

Open
1 task
akosyakov opened this issue Apr 26, 2019 · 1 comment
Open
1 task

fix handling of vscode configuration scopes #5021

akosyakov opened this issue Apr 26, 2019 · 1 comment
Labels
preferences issues related to preferences vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Apr 26, 2019

See #4947 (comment)

TODO

  • update CHANGELOG from user perspective
@akosyakov akosyakov added preferences issues related to preferences vscode issues related to VSCode compatibility labels Apr 26, 2019
@colin-grant-work
Copy link
Contributor

@akosyakov, could you expand a little on the functionality that this issue is targeting? From the comment and the reference to the VSCode repo, it looks like the objective is to accurately reflect superset properties of scopes (User ⊃ Workspace ⊃ Folder), so anything valid in folder scope is valid in WS and User, and anything valid in WS is valid in User, but not vice versa. That needs to be reflected in how the schemas for each scope are updated and how the isValidInScope check works, correct? I think a lot of that work may already have been done, but I want to make sure I understand correctly what the desired functionality is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants