Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin api: theia#workspace#getConfiguration doesn't handle resource argument. #2290

Closed
AndrienkoAleksandr opened this issue Jul 6, 2018 · 1 comment · Fixed by #4947
Closed

Plugin api: theia#workspace#getConfiguration doesn't handle resource argument. #2290

AndrienkoAleksandr opened this issue Jul 6, 2018 · 1 comment · Fixed by #4947
Assignees
@akurinnoy
Labels
plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility

Comments

@AndrienkoAleksandr
Copy link
Contributor

Plugin api: theia#workspace#getConfiguration(section?: string, resource?: Uri | null) doesn't handle resource argument.
https://github.com/theia-ide/theia/blob/master/packages/plugin/src/theia.d.ts#L2397
When Theia will provide multiroot workspace we should support get configuration for workspace folder by resource path.
@AndrienkoAleksandr AndrienkoAleksandr added plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team labels Jul 6, 2018
@AndrienkoAleksandr
Copy link
Contributor Author

Depends on multi-root workspace: #2117

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Jul 31, 2018
Closed
@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Feb 6, 2019
@akurinnoy akurinnoy mentioned this issue Feb 14, 2019
Closed
@akurinnoy akurinnoy self-assigned this Mar 14, 2019
@akurinnoy akurinnoy mentioned this issue Apr 1, 2019
Closed
@akosyakov akosyakov mentioned this issue Apr 26, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
3 participants
@AndrienkoAleksandr @tsmaeder @akurinnoy