CommandLineSettingTest is never executed

[sophokles73]

The core/src/test/java/org/eclipse/dash/licenses/tests/TestSuite.java defines the test suite to be run as all class files ending in Tests.

This results in the tests defined in CommandLineSettingTest.java never being run. However, running the tests manually reveals that they fail for the current code base.

[waynebeaton]

Well that's embarrassing... I'll have a look.

[sophokles73]

I have taken a look at the whole command line parsing which is currently based on the (rather inept) Apache Commons CLI library. IMHO we could save a lot of manual coding if we used something more capable like picocli. Or is there any compelling reason why we would need to stick with Commons CLI? If not, I guess I could give it a shot...

[waynebeaton]

There was no specific compelling reason behind the selection of Apache Commons CLI.

One thing that's bothered me about the implementation of the settings is that it tightly couples components that are otherwise more loosely coupled. It's possible to, for example, create a configuration of the Dash License Tool that drops ClearlyDefined support or IPLab integration, but the configuration of them will still be in the settings. I've thus far avoided attempting to refactor any of that because I expect that it will introduce unnecessary complexity.

[waynebeaton]

The errors are a result of some housekeeping that I did last week (see #427). Had the tests been included in the suite, I'd have noticed the error. I'll reverse those, and add CommandLineSettingTest to the test suite. This should clean up the errors.

[waynebeaton]

3ce24e0 changes the name from CommandLineSettingTest to CommonLineSettingTests to ensure that the tests are run. The errors introduced by the previous commit have been reverted. The tests should run clean now.

[waynebeaton]

I've pushed further update that correctly configure the batch, confidence, and timeout options as Integer.class.