-
Notifications
You must be signed in to change notification settings - Fork 114
Update python tooling image #93
Conversation
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
devfiles/python/devfile.yaml
Outdated
@@ -16,7 +16,7 @@ components: | |||
- | |||
type: dockerimage | |||
alias: python | |||
image: quay.io/eclipse/che-python-3.6:nightly | |||
image: centos/python-36-centos7:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use python:3.7.4-slim
to be consistent with the LS sidecar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command to install dependencies for the Django project failed due to permissions
ERROR: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python3.7/site-packages/django'
Consider using the `--user` option or check the permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can use image with python 3.6 for a sidecar container instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the purpose of this PR. Why are we moving away from using the arbitrary-user-id patched image?
For context, quay.io/eclipse/che-python-3.6:nightly
is centos/python-36-centos7:1
with patches to support running on OpenShift.
@amisevsk |
@tolusha I think the misunderstanding is that, to update the image, you should modify the @amisevsk the goal here was to make the python base image consistent with python LS sidecar image eclipse-che/che-theia#427 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that I'm clear, updating base_images
to point to python:3.7.4-slim
does not work because the pip install
command fails? Have we tried updating the devfile to use --user
?
@amisevsk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approving quite yet since I'd like to test the new image before merging.
I've created the quay.io repo https://quay.io/repository/eclipse/che-python-3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested python-django devfile with changes and using patched image based off python:3.7.4-slim:
- I was able to connect a debugger to the running application in the main container
- I believe the
install dependencies
task will have to be run every start, sincepip --user install
installs to~/.local/
, which is not persisted.
- I believe the
- I get error markers on imports ([pylint] Unable to import 'rest_framework') for non-project imports.
Before merging, please update python devfiles to use quay.io/eclipse/che-python-3.7:nightly
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Updates python tooling image:
quay.io/eclipse/che-python-3.6:nightly
->centos/python-36-centos7:1