From eda5189ad7e57bb5da7512023e2d1c29e56e752f Mon Sep 17 00:00:00 2001 From: ebuddenberg Date: Mon, 20 Feb 2023 17:49:09 -0700 Subject: [PATCH] Pins GitHub actions to Node 16 (#2010) ## Description - Pins GitHub actions that now default to node 18 to node 16 - sets node engine to 16 in `package.json` ## Motivation and Context All of our jest tests the imported files using `data-forge` were failing to run. Something must break when running on node 18 (the new default) instead of node 16, so for now this PR pins our yaml files to node 16 https://github.com/actions/runner-images/issues/7002 ## Has this been tested? How? Tests are passing again ## Types of changes - Chore (developer productivity fix that doesn't affect the user) --- .github/workflows/node.js.yml | 5 ++--- .github/workflows/urlsScheduled.yml | 5 ++--- frontend/package.json | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index f708d7bd..b7600a8f 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -19,10 +19,9 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Run tests with Node.js 16.13.0 - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: - node-version: 16.13.0 + node-version: 16 - run: npm install - run: npm run cspell - run: npm run build diff --git a/.github/workflows/urlsScheduled.yml b/.github/workflows/urlsScheduled.yml index 81ba75ea..104dd836 100644 --- a/.github/workflows/urlsScheduled.yml +++ b/.github/workflows/urlsScheduled.yml @@ -15,10 +15,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - name: Run tests with Node.js 16.13.0 - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: - node-version: 16.13.0 + node-version: 16 - run: npm install - run: npm run build - run: npm run url diff --git a/frontend/package.json b/frontend/package.json index fcac1f14..116a2efd 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -101,7 +101,7 @@ "extends": "react-app" }, "engines": { - "node": ">=12.19.0", + "node": ">=16", "npm": ">=6.14.8" }, "browserslist": {