Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional speaker setups to DirectSpeakers plugin #30

Closed
rsjbailey opened this issue Jan 15, 2021 · 0 comments · Fixed by #89
Closed

Add additional speaker setups to DirectSpeakers plugin #30

rsjbailey opened this issue Jan 15, 2021 · 0 comments · Fixed by #89
Labels
enhancement New feature or request

Comments

@rsjbailey
Copy link
Contributor

For the monitoring plugins it makes sense to limit ourselves to the setups in BS.2051, but I realised, that this does not really make sense for the DirectSpeakers plugin. It is reasonable to assume, that one e.g. might also want to add a 5.0 source to a mix.
Does it make sense to allow all the setups which are defined in the common definitions?

(comment)
I think so. You're never going to get complaints that you support too many speaker layouts :) but you might if someone tries to import an ADM file with a common def directspeakers pack that isn't supported.

I allow all in the ADM Export VST, simply because they may be useful and it's no extra effort to include them. In fact, with the way that code works, it would have been more effort to exclude some - I just iterate common def pack formats with the directspeakers type definition and use a simple string manipulation method to make a "friendly" name out of the pack format names.

Copied From Issue 144 on gitlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant