Export Comms and Render Dialog fixes #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to listen to see if free will just disrupt comms on anything already using the socket. Just stat it instead.
When all plugins destroyed, nng_fini is called via NngSelfRegister and NngFinaliser. However, this means if new plugins are then instantiated, the NNG globals on the heap have already been cleared down, and the new plugins can not communicate!
Led to occasional crash in free()
We can't guarantee destruction order of extension and plugins, so can cause a hang (this is why it was disabled originally) nng_fini isn't necessary anyway according to docs
Irrelevant - we can only render at project sample rate anyway due to how audio comms works
will not work for our system as normalisation would be applied to sink feed and we don't use the sink feed anyway
Causes mismatch between received blocks and expected received blocks of audio. Can't imagine it's of much use anyway.
rsjbailey
force-pushed
the
render-dialog-fixes
branch
from
c38e740 to
d4b5943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the comms-fixes and render-dialog-fixes branches (latter is based off the former)
Export Comms Fixes
Problem: Hang on OSX when trying to render after instantiating either an ADM Export Source or EAR Scene plugin after another EAR Scene.
Issue: It seems that an
nng_listenon POSIX systems for a REQ-REP connection will return anNNG_EADDRINUSEif the address is being used (as expected) but in the process it disrupts the connection already on there. No messages are delivered on that connection anymore and they don't even time out - just hang.Fix: For posix since it's all based around the filesystem, we can just do a
statto see if the address is in use without disturbing it.Sub-problem: "Command" addresses are not being reused once released.
Issue: Sockets not destroyed
Fix: Destroy socket in Processor destructor
Sub-problem: Reused "Command" addresses are not working after deleting and re-adding a Scene plugin
Issue: There is a
NngSelfRegistermechanism which attempts to keep track of everything using NNG and callsnng_finito clear up globals once all usages are gone. If you delete the final plugin using NNG,nng_finiis called. If you then launch a new plugin, the sockets are unresponsive.Fix: Don't bother with
NngSelfRegisterandnng_fini- it's not necessary anyway: https://github.com/nanomsg/nng/blob/722bf4621703ef238fa81018f8c3e68bcef91354/include/nng/nng.h#L211 . I attempted to let the extension handle thenng_finicall, but you can't guarantee destruction order of extension and plugins, so can get some nasty crashes - just keep it simple and don't usenng_finiat all.Render Dialog Fixes
Problem: Getting a crash deep down in
free()sometimes on windows when exiting REAPER. Long-term problem but hasn't caused any real problem since it's on exit.Issue: Came down to the overly complex singleton pattern in render dialog code.
Fix: Didn't bother figuring out why it wasn't working - just replaced with a much simpler pattern which fixed it anyway.
Problem: Tested with REAPER v6.58 and there are some new Render options not applicable to OBA. They needed disabling.
Fix: Disable options using existing control look-up code and OS API (or via SWELL) calls.