Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[GCCcore/12.3.0] chopper v0.9.0 #21418

Merged

Conversation

akesandgren
Copy link
Contributor

(created using eb --new-pr)

@boegel
Copy link
Member

boegel commented Sep 17, 2024

@akesandgren Some minor style issues to fix:

chopper-0.9.0-GCCcore-12.3.0.eb:306:1: W293 blank line contains whitespace
chopper-0.9.0-GCCcore-12.3.0.eb:306:1: W293 blank line contains whitespace

(ignore the checksum issue, that's fixed with #21419)

@boegel
Copy link
Member

boegel commented Sep 17, 2024

Also, duplicate of:

@boegel
Copy link
Member

boegel commented Sep 17, 2024

Also, duplicate of:

* [{bio}[GCC/12.3.0] chopper v0.9.0 #21388](https://github.com/easybuilders/easybuild-easyconfigs/pull/21388)

Actually, we should favor this PR over #21388, since this includes a patch file to fix the chopper version issue

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove whitespace from empty line in chopper easyconfig

@boegel
Copy link
Member

boegel commented Sep 17, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21418 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21418 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14277

Test results coming soon (I hope)...

- notification for comment with ID 2354756545 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f46191d854220842b4d88e1a8dba276a for a full test report.

@boegel
Copy link
Member

boegel commented Sep 17, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21418 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21418 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4884

Test results coming soon (I hope)...

- notification for comment with ID 2354813232 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d9a720c2cd5a830bdf22ddca7a9d7e20 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 17, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3105.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/c07438c5f266734dee2e2ddc32c599f4 for a full test report.

@boegel boegel added this to the release after 4.9.3 milestone Sep 17, 2024
@boegel
Copy link
Member

boegel commented Sep 17, 2024

Going in, thanks @akesandgren!

@boegel boegel merged commit b841c06 into easybuilders:develop Sep 17, 2024
9 checks passed
@akesandgren akesandgren deleted the 20240916102549_new_pr_chopper090 branch September 17, 2024 13:40
@boegel boegel modified the milestones: release after 4.9.4, 4.9.4 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants