From 5497219a66e83185f81b1b18a539342b3ba04e04 Mon Sep 17 00:00:00 2001 From: Tommy Ludwig <8924140+shakuzen@users.noreply.github.com> Date: Tue, 21 Nov 2023 17:58:20 +0900 Subject: [PATCH] Do not upgrade hystrix dependency metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily. --- .github/dependabot.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 7b6e459696..aefa1c774d 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -12,6 +12,10 @@ updates: target-branch: "1.9.x" milestone: 136 ignore: + # metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced + # in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. + # <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily. + - dependency-name: "com.netflix.hystrix:hystrix-core" # only upgrade patch versions - dependency-name: "*" update-types: @@ -25,6 +29,10 @@ updates: target-branch: "1.10.x" milestone: 159 ignore: + # metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced + # in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. + # <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily. + - dependency-name: "com.netflix.hystrix:hystrix-core" # only upgrade patch versions - dependency-name: "*" update-types: @@ -38,6 +46,10 @@ updates: target-branch: "1.11.x" milestone: 206 ignore: + # metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced + # in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. + # <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily. + - dependency-name: "com.netflix.hystrix:hystrix-core" # only upgrade patch versions - dependency-name: "*" update-types: @@ -51,6 +63,10 @@ updates: target-branch: "1.12.x" milestone: 211 ignore: + # metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced + # in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. + # <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily. + - dependency-name: "com.netflix.hystrix:hystrix-core" # only upgrade patch versions - dependency-name: "*" update-types: @@ -64,6 +80,10 @@ updates: target-branch: "main" milestone: 185 ignore: + # metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced + # in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. + # <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily. + - dependency-name: "com.netflix.hystrix:hystrix-core" # upgrade minor and patch versions on main - dependency-name: "*" update-types: