chore: linting things

Author: dylanarmstrong

.gitignore

@@ -1,2 +1,3 @@
+node_modules
 !styles/*.css
 *.css

README.md

@@ -1,6 +1,7 @@
 ## Userscripts and Userstyles
 
 ### Notes
+
 My personal collection of userscripts. These can all be used independently of each other, so just grab the ones that sound interesting. I primarily use Safari, and haven't tested any of these in other browsers. If you run into issues, please open an issue.
 
 From Sept. 2020 onwards, these are designed and being updated to work with [Userscripts](https://github.com/quoid/userscripts) instead of Tampermonkey.
@@ -12,100 +13,122 @@ Archived scripts are stored in archive folder.
 ### Scripts
 
 #### ban-hn
+
 HN has really bad moderation, so this enables me to automatically hide cancerous people that I spot on there.
 
 #### chess
+
 Add button to analyze games on lichess.org on game-over screen for chess.com
 
 #### cnbc
+
 CNBC is removing the article because of my adblocking, so double the article, it won't remove both.
 
 #### fakespot
+
 Add fakespot link above buy box on amazon
 
 #### fanfiction
+
 Modify fanfiction.net to be better. There's a customizable cors proxy url that can be used on the profile page.
 If you change this to your own, you can view mobile favorites (without 500 limit) on the desktop.
 
-#### google-placeholder
-Pulled in some uBlock scripts that have drop-in no-op replacements for google tracking, might cause less sites to break.
-
 #### guardian
-Attempt to fix some of the annoyances I'm encountering on theguardian. This doesn't really work yet, but it's a first step towards pulling out content and replacing entire page.
 
-#### imgur
-Bypass imgur login
+Attempt to fix some of the annoyances I'm encountering on theguardian. This doesn't really work yet, but it's a first step towards pulling out content and replacing entire page.
 
 #### logic-immo
-Fix this site so it works with adblock
-
-#### reddit-filter
-Adds a filter at end of tagline that has a popup to filter on subreddit, domain, or user (only on r/all). They're stored in the localStorage keys starting with 'filter'. Filtered items must be removed from localStorage manually.
-
-![reddit-filter screenshot](./screenshots/reddit-filter.png)
 
-#### reddit-load
-When you scroll to the bottom, load the next page of results. Compatible with reddit-filter.
-
-#### reddit-nsfw
-Filter all NSFW tags from appearing on any page
-
-#### reddit-override
-Override Reddit's official window.r functionality that *may* be interesting, I don't really know. The isMobile method stops video pinning though, which is useful.
+Fix this site so it works with adblock
 
 #### reddit-redirect
-Redirects www calls to old.reddit.com
 
-#### uBlock-Origin-dev-filter
-Hides the crappy domains from DuckDuckGo & Google. PR [here](https://github.com/quenhus/uBlock-Origin-dev-filter/pull/12) for userscript output support.
+Redirects www calls to old.reddit.com
 
 #### wikipedia-chess
+
 Fixes chessboards on Safari wikipedia
 
 #### wikipedia-nag
+
 Removes donation nag on wikipedia
 
 #### xenforo-popular
+
 Hides unpopular stories on spacebattles / sufficientvelocity, so it's easier to go through recently updated and find good stories.
 
 #### xenforo-reactions
+
 Adds first message reaction score on alternate-history, sufficientvelocity and spacebattles.
 
 ### Styles
-* amazon
-* bloomberg
-* chess
-* duckduckgo
-* fanfiction
-* gamepedia
-* hacker-news
-* guardian
-* lemonde
-* overflow (`overflow: auto` on body/html)
-* reddit
-* royalroad
-* speedrun
-* teddit
-* wormstorysearch
-* xenforo
-* youtube
+
+- amazon
+- bloomberg
+- chess
+- duckduckgo
+- fanfiction
+- gamepedia
+- hacker-news
+- guardian
+- lemonde
+- overflow (`overflow: auto` on body/html)
+- reddit
+- royalroad
+- speedrun
+- teddit
+- wormstorysearch
+- xenforo
+- youtube
 
 ### Archived Scripts
-These scripts are ones I am not actively maintaining, they may continue to work. If you run into an issue with them, please open an issue and I will take a look.
+
+#### imgur [archived]
+
+Bypass imgur login
+
+#### google-placeholder [archived]
+
+Pulled in some uBlock scripts that have drop-in no-op replacements for google tracking, might cause less sites to break.
+
+These scripts are ones I am not actively maintaining, they may continue to work.
 
 #### facebook-marketplace [archived]
+
 Sort facebook marketplace by date
 
 #### facebook-marketplace-local-only [archived]
+
 Remove 'Ships to you' items from marketplace. I'm not sure this does what I want, but it's somewhat useful at the moment.
 
 #### outline [archived]
+
 Open some outgoing links (mostly news) from HN and Reddit using the awesome [outline.com](https://outline.com) service.
 
 #### paradoxwikis [archived]
+
 Achievements page on EU4 wiki is using some new mobile style, so just delete it all and use no style. Tables are usable as-is.
 
+#### reddit-filter [archived]
+
+Adds a filter at end of tagline that has a popup to filter on subreddit, domain, or user (only on r/all). They're stored in the localStorage keys starting with 'filter'. Filtered items must be removed from localStorage manually.
+
+![reddit-filter screenshot](./screenshots/reddit-filter.png)
+
+#### reddit-load [archived]
+
+When you scroll to the bottom, load the next page of results. Compatible with reddit-filter.
+
+#### reddit-nsfw [archived]
+
+Filter all NSFW tags from appearing on any page
+
+#### reddit-override [archived]
+
+Override Reddit's official window.r functionality that _may_ be interesting, I don't really know. The isMobile method stops video pinning though, which is useful.
+
 #### stylize [archived]
+
 Allows me to write custom styles for websites matching hosts by string or regex. Not very user friendly and you'd be best off copying the js directly into your tampermonkey extension and ignoring updates.
 
 Replaced with styles in Cascadea.
@@ -118,27 +141,35 @@ const csses = {
       .subreddit {
         border: 1px solid blue;
       }
-    `
+    `,
   },
   'old.reddit.com': {
     type: 'string',
     css: `
       .subreddit {
         border: 1px solid red;
       }
-    `
-  }
+    `,
+  },
 };
 ```
 
+#### uBlock-Origin-dev-filter [archived]
+
+Hides the crappy domains from DuckDuckGo & Google. PR [here](https://github.com/quenhus/uBlock-Origin-dev-filter/pull/12) for userscript output support.
+
 #### xenforo-no-fanwork [archived]
+
 Remove fanwork discussions from main user forum on sufficientvelocity
 
 #### xenforo-no-worm [archived]
+
 Remove worm stories, except from worm specific forums
 
 #### xenforo-search [archived]
+
 Remove posts from search results, only show threads
 
 #### youtube [archived]
+
 Disable youtube polymer

google-placeholder.js archive/google-placeholder.js

@@ -7,16 +7,14 @@
 // @namespace    https://github.com/dylanarmstrong/userscripts/
 // @supportURL   https://github.com/dylanarmstrong/userscripts/issues
 // @updateURL    https://raw.githubusercontent.com/dylanarmstrong/userscripts/main/ban-hn.js
-// @version      2
+// @version      3
 // ==/UserScript==
 
 /**
  * HN has really bad moderation, so it's easier to just block the people who are cancer.
  */
 
-(function () {
-  'use strict';
-
+(function main() {
   // Store the version # in localStorage
   // this will be useful for possible breaking changes
   // How many ? can you fit on one line?
@@ -48,15 +46,15 @@
   localStorage.setItem(keys.version, version);
 
   // Make a (x) button next to subhn
-  let button = document.createElement('button');
+  const button = document.createElement('button');
   button.classList.add('hn-filter-block');
 
-  let nodes = null;
+  let nodes;
 
   const updateNodes = () => {
-    nodes = Array.from(
-      document.querySelectorAll('.comment-tree .comhead'),
-    ).filter((node) => node !== null && typeof node !== 'undefined');
+    nodes = [...document.querySelectorAll('.comment-tree .comhead')].filter(
+      (node) => node !== null && node !== undefined,
+    );
   };
 
   const getUser = (node) =>
@@ -70,27 +68,38 @@
 
   // Remove all blocked subhns
   const hide = () => {
-    for (let i = 0, len = nodes.length; i < len; i++) {
-      const node = nodes[i];
+    for (let index = 0, length_ = nodes.length; index < length_; index++) {
+      const node = nodes[index];
       const user = getUser(node);
-      if (isBanned(user)) {
-        // Check if already hidden
-        if (
-          !node.parentNode.parentNode.parentNode.parentNode.querySelector(
-            '.noshow',
-          )
-        ) {
-          node.parentNode.parentNode.querySelector('a.togg.clicky').click();
-        }
+      if (
+        isBanned(user) && // Check if already hidden
+        !node.parentNode.parentNode.parentNode.parentNode.querySelector(
+          '.noshow',
+        )
+      ) {
+        node.parentNode.parentNode.querySelector('a.togg.clicky').click();
+      }
+    }
+  };
+
+  const updateButtons = () => {
+    for (let index = 0, length_ = nodes.length; index < length_; index++) {
+      const node = nodes[index];
+      const a = node.querySelector('.hn-filter-span a');
+      const user = getUser(node);
+      const reason = getData()[user];
+      if (reason !== undefined) {
+        a.title = reason;
       }
+      a.textContent = isBanned(user) ? 'unban' : 'ban';
     }
   };
 
-  const click = (e) => {
-    e.preventDefault();
-    e.stopPropagation();
+  const click = (event) => {
+    event.preventDefault();
+    event.stopPropagation();
 
-    const { target } = e;
+    const { target } = event;
     const title =
       target.parentNode.parentNode.parentNode.parentNode.querySelector(
         '.commtext',
@@ -102,6 +111,7 @@
     const data = getData();
 
     if (
+      // eslint-disable-next-line no-alert
       confirm(
         `Are you sure you want to ${banned ? 'unblock' : 'block'} '${user}'?`,
       )
@@ -118,22 +128,9 @@
     }
   };
 
-  const updateButtons = () => {
-    for (let i = 0, len = nodes.length; i < len; i++) {
-      const node = nodes[i];
-      const a = node.querySelector('.hn-filter-span a');
-      const user = getUser(node);
-      const reason = getData()[user];
-      if (reason !== undefined) {
-        a.title = reason;
-      }
-      a.textContent = isBanned(user) ? 'unban' : 'ban';
-    }
-  };
-
   const addButtons = () => {
-    for (let i = 0, len = nodes.length; i < len; i++) {
-      const node = nodes[i];
+    for (let index = 0, length_ = nodes.length; index < length_; index++) {
+      const node = nodes[index];
       if (!node.querySelector('.hn-filter-span')) {
         const span = document.createElement('span');
         span.classList.add('hn-filter-span');
@@ -145,9 +142,9 @@
         }
         a.textContent = isBanned(user) ? 'unban' : 'ban';
         a.addEventListener('click', click);
-        span.insertAdjacentText('afterbegin', ' | ');
-        span.appendChild(a);
-        node.appendChild(span);
+        span.prepend(' | ');
+        span.append(a);
+        node.append(span);
       }
     }
   };

imgur.js archive/imgur.js

@@ -1,26 +1,24 @@
 // ==UserScript==
 // @name         cnbc
 // @namespace    https://github.com/dylanarmstrong/userscripts/
-// @version      2
+// @version      3
 // @description  cnbc is accidentally unloading the article b/c of adblocking
 // @author       dylanarmstrong
 // @match        https://www.cnbc.com/*
-// @updateURL    https://raw.githubusercontent.com/dylanarmstrong/userscripts/master/cnbc.js
+// @updateURL    https://raw.githubusercontent.com/dylanarmstrong/userscripts/main/cnbc.js
 // @supportURL   https://github.com/dylanarmstrong/userscripts/issues
 // @grant        none
 // @run-at       document-end
 // ==/UserScript==
 
-'use strict';
-
 /*
  * CNBC keeps breaking their site.
  * I really need to just ditch the whole site and pull out the text for their articles.
  */
 
-(function() {
+(function main() {
   const copy = () => {
-    const art = document.getElementById('MainContent');
+    const art = document.querySelector('#MainContent');
     if (art && art.querySelector('.Article.PageBuilder-page')) {
       const clone = art.cloneNode(true);
       clone.id = 'FakeMainContent';