-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a mechanism for URL rewriting before viewing #141
Comments
This sounds great. [1] https://jupyter-server-proxy.readthedocs.io/en/latest/arbitrary-ports-hosts.html |
Looking at the docs linked seems like the final address can be known server side beforehand. It should be something like the below, no?
|
No, this is just for direct access to the port. The URL of a Xpra launched with the launcher-extension https://github.com/FZJ-JSC/jupyter-xprahtml5-proxy would be for example something like: |
@jhgoebbert, I'm not familiar with your setup, but to render the Inspector inline in a Jupyter notebook, all one needs (if it runs JHub/JLab through reverse proxy) is support for Please correct me if I'm wrong. |
@randomir Great, this is fantastic! Thank you for your work and the code update! |
For usage example, see #144 (comment). |
Sometimes the inspector server runs on host A, but is exposed (proxied) as host B, which is then made available to the user (while A might not be).
To support this use case we can introduce a framework of pluggable URL rewriters, similarly to what we do with viewers. A URL rewriter would be called just before the call to
view()
, or as part of it.For a motivating example, see #109 (comment).
The text was updated successfully, but these errors were encountered: