Fix full no_std compatibility #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZER0
requested changes
Mar 11, 2021
There was a problem hiding this comment.
Few questions to understand, plus I assuming this is solely needed at this moment due to dusk-plonk in no-std is that correct?
In that case, I will postpone the release of bls as well to the next iteration, however I would fix the broken_intra_doc_links (so I would create a different PR for that, as you did for jubjub)
Cargo.toml
Outdated
| dusk-bytes = "0.1" | ||
| dusk-bls12_381 = {version="0.6", default-features=false} | ||
| subtle = {version="^2.3", default-features = false} | ||
| rand_core = {version = "0.5", default-features=false} | ||
| subtle = {version="2.0", default-features = false} |
There was a problem hiding this comment.
Care to elaborate this downgrade…?
What are we gaining, what are we losing?
| subtle = {version="^2.3", default-features = false} | ||
| rand_core = {version = "0.5", default-features=false} | ||
| subtle = {version="2.0", default-features = false} | ||
| rand_core = {version = "0.6", default-features=false} |
There was a problem hiding this comment.
To make it no_std compatible with the new random crates. This seems to be the direction that Rust ecosystem is taking. Moving away from rand to rand_core.
CPerezz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #66
NOTE Will merge as soon as dusk-network/bls12_381#55 is merged