Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElGamal encryption scheme #32

Merged
merged 6 commits into from
Aug 13, 2020
Merged

ElGamal encryption scheme #32

merged 6 commits into from
Aug 13, 2020

Conversation

vlopes11
Copy link

Implements #28 and #31

Not using inverted secret

@CPerezz CPerezz requested a review from khovratovich August 12, 2020 06:57
@CPerezz
Copy link

CPerezz commented Aug 12, 2020

Will wait for @khovratovich theoretical review. Then I'll add mine

@CPerezz CPerezz added area:cryptography anything related to cryptographic primitives, hashing and ZKP type:feature implementing a new feature labels Aug 12, 2020
@vlopes11 vlopes11 marked this pull request as draft August 12, 2020 14:47
@vlopes11 vlopes11 marked this pull request as ready for review August 12, 2020 22:25
@vlopes11
ElGamal - Documentation improvement
caccbee
@vlopes11
Implements #31 - Generators available as extended
1151160 
Every in-memory operation is performed with extended points, so the user
of the API will always need to convert the Affine Points to extend
before performing the operations.

To facilitate, we made available by default the generators also in
extended form.
@vlopes11
Merge branch 'vlopes11/generator' into vlopes11/elgamal
008b276
CPerezz
CPerezz approved these changes Aug 13, 2020
View reviewed changes
Copy link

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPerezz CPerezz self-requested a review August 13, 2020 07:52
CPerezz
CPerezz suggested changes Aug 13, 2020
View reviewed changes
LukePearson1
LukePearson1 approved these changes Aug 13, 2020
View reviewed changes
Copy link

@LukePearson1 LukePearson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. As several points were raised on the additivity of Elliptic curve groups, that notation is well ironed out and clarifies the steps on this PR.

@LukePearson1 LukePearson1 mentioned this pull request Aug 13, 2020
Closed
@CPerezz CPerezz self-requested a review August 13, 2020 11:49
CPerezz
CPerezz approved these changes Aug 13, 2020
View reviewed changes
Copy link

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlopes11 vlopes11 merged commit c9547bf into master Aug 13, 2020
@vlopes11 vlopes11 deleted the vlopes11/elgamal branch August 13, 2020 11:52
@vlopes11 vlopes11 mentioned this pull request Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukePearson1 LukePearson1 LukePearson1 approved these changes

@CPerezz CPerezz CPerezz approved these changes

@khovratovich khovratovich Awaiting requested review from khovratovich

Assignees

@vlopes11 vlopes11

Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP type:feature implementing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlopes11 @CPerezz @LukePearson1