Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check is_on_curve for jubjub points #137

Closed
moCello opened this issue Apr 24, 2024 · 0 comments · Fixed by #138
Closed

Add check is_on_curve for jubjub points #137

moCello opened this issue Apr 24, 2024 · 0 comments · Fixed by #138

Comments

@moCello
Copy link
Member

moCello commented Apr 24, 2024

Summary

We can check whether a point if the identity point and if it's part of the prime-order subgroup, but there is no check implemented that makes sure a point struct also verifies the curve equation, i.e. that the point actually is on the curve.

Possible solution design or implementation

Follow the implementation for the bls-points: https://docs.rs/dusk-bls12_381/latest/dusk_bls12_381/struct.G1Affine.html#method.is_on_curve

Additional context

This is needed to check for point validity in signature verification dusk-network/jubjub-schnorr#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant