This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Fix Plugin Parsing #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where having a plugin with preferences followed by a plugin with no preferences would not properly reset hasVariables and variable list
|
to me this looks like a bug introduced by pr #33 8884f4a#diff-2251310b0ef732442230e91e2715d586 |
|
@dwieeb I'm sure you get notified on this but just want to ping you so you know there is an issue on the latest release (0.6.2). I have a feeling this will be a common problem for end users with more than a couple plugins. |
|
One more comment for SEO purposes, you will see an error like below if you are affected by this:
(replace URL_SCHEME with completely random var of previous plugin) |
|
Nice work. I'll have a new version out as soon as I can. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where having a plugin with preferences followed by a plugin with no preferences would not properly reset hasVariables and variable list.