Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache line ranges of chunks for fast lookup #75

Open
drahnr opened this issue Jul 23, 2020 · 1 comment
Open

cache line ranges of chunks for fast lookup #75

drahnr opened this issue Jul 23, 2020 · 1 comment
Assignees
Labels
enhancement 🦚 New feature or request heavy-duty 🚜 Big features not easy to implement

Comments

@drahnr
Copy link
Owner

drahnr commented Jul 23, 2020

Is your feature request related to a use-case? Please describe.
Currently performance of #74 is far from acceptable, taking multiple seconds to complete for a small~ish codebase.

Describe the solution you'd like
The majority added delay comes from parsing CheckableChunk over and over again in order to convert ranges to spans and vice versa.

Describe alternatives you've considered
Not really many other options here, we need to get rid of the O(n) and make it a O(1) or O(log n) at least.

@drahnr drahnr added enhancement 🦚 New feature or request heavy-duty 🚜 Big features not easy to implement labels Jul 23, 2020
@drahnr drahnr self-assigned this Jul 23, 2020
@drahnr drahnr added this to the v0.4.0 milestone Jul 23, 2020
@drahnr
Copy link
Owner Author

drahnr commented Jul 28, 2020

@laysauchoa would you be interested in looking into this? Or do you fancy another issue?

@drahnr drahnr modified the milestones: v0.4.0, v0.5.0 Aug 17, 2020
@drahnr drahnr modified the milestones: v0.5.0, v0.6.0 Sep 10, 2020
@drahnr drahnr removed this from the v0.8.0 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🦚 New feature or request heavy-duty 🚜 Big features not easy to implement
Projects
None yet
Development

No branches or pull requests

1 participant