Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oklab <-> Color3 conversions do not use sRGB transfer functions #257

Closed
dphfox opened this issue Jun 21, 2023 · 0 comments · Fixed by #283
Closed

Oklab <-> Color3 conversions do not use sRGB transfer functions #257

dphfox opened this issue Jun 21, 2023 · 0 comments · Fixed by #283
Labels
broken Something isn't right ready to work on Enhancements/changes ready to be made

Comments

@dphfox
Copy link
Owner

dphfox commented Jun 21, 2023

Right now, Color3s are treated as linear RGB data, even though Roblox uses them as sRGB in many places throughout the engine. This should be accounted for, at minimum the sRGB transfer functions could be added, but ideally choices about colour gamut should be left to the user based on what kind of colour work they are doing.

@dphfox dphfox added broken Something isn't right ready to work on Enhancements/changes ready to be made area: internal labels Jun 21, 2023
@dphfox dphfox moved this to Prospective in Fusion 0.3 Jun 21, 2023
@github-project-automation github-project-automation bot moved this from Prospective to Done in Fusion 0.3 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken Something isn't right ready to work on Enhancements/changes ready to be made
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant